- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable jumping to "not formatted" files from VisualStudio error list #1517
Merged
+77
−14
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
dbced62
feat: enable jumping to "not formatted" files from VisualStudio error…
moormaster 76a7c4b
refactor: simplified FileIssueLogger.WriteError()
moormaster 7091394
refactor: format ConsoleLogger
moormaster 3fc1a8a
refactor: convert --msbuild-format into --log-format <console|msBuild>
moormaster ec1dac0
feat: also format Warnings according to --log-output
moormaster d129892
refactor: remove unused constants from CommandLineFormatterTests
moormaster 7dc0fc6
Merge branch 'main' into feat/add-msbuild-format-output
belav 70aaa06
Remove TODO, unable to figure out how to get a warning in msbuild
belav 8ad357c
Merge branch 'main' into feat/add-msbuild-format-output
belav 4a88a6d
formatting files
belav bd5b14e
Merge branch 'feat/add-msbuild-format-output' of https://github.com/m…
belav c1e8b07
Merge branch 'main' into feat/add-msbuild-format-output
belav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: simplified FileIssueLogger.WriteError()
commit 76a7c4b9138e545dd008468fc00f8728138b72de
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
WriteWarning
message should also use msbuild format. Although I don't recall what is considered a warning by CSharpier, and we turn onwarningsAsErrors
at work. Maybe that would cause issues.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also made WriteWarning() obey the --log-format parameter.
Also added a TODO comment for adding a test as soon as it is clear in which situations CSharpier will output warnings.