Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Location option extension #3177

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Location option extension #3177

wants to merge 8 commits into from
+86 −6

Conversation

kloknibor
Copy link
Contributor

This PR adds additional location tracking modes. On top of continuous it also adds the tracking of visits and significant location changed.

This allows for a more battery balanced way of tracking

Refs #3085

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

freakboy3742
freakboy3742 requested changes Feb 10, 2025
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The broad strokes of this looks good. A couple of minor comments inline; a broader design question in the original ticket.

@freakboy3742 freakboy3742 mentioned this pull request Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kloknibor @freakboy3742