-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add artist, album to item entry template in the web plugin #5753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add artist, album to item entry template in the web plugin #5753
Conversation
2f5a49b
to
977559c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the web plugin by displaying additional metadata in the search results, showing the artist and album along with the title.
- Updates the changelog with a new entry for the web plugin.
- Modifies the item entry template in the web plugin to include artist and album information.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
docs/changelog.rst | Added a changelog entry for updated search result display. |
beetsplug/web/templates/index.html | Updated the item entry template to show "artist – album – title". |
977559c
to
ab7b7a2
Compare
handling cases where the artist or album data might be missing to avoid rendering extraneous separators. Suggested by Copilot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@matlads Would you mind moving your changelog note to the Unreleased section? |
Done. I have a question about this, though. Why not leave the changelog entry where it was? When beets gets a new release, this section will have to be copied over to the 'New features' or whichever section is relevant. It sort of undoes this last commit. I may have missed something in some discussion or documentation, so any pointers would be helpful. Thanks. |
You should indeed place it under the relevant subsection! (New features in this case). When I looked at this yesterday, it seemed like the note was under section |
After some guidance from @snejus this is the proper place to place the change log entries, not inside the New features section of _released_ versions.
All done. Thanks for the pointer. |
After some guidance from @snejus this is the proper place to place the change log entries, not inside the New features section of _released_ versions.
Description
Add the artist and album information to the item template in the web plugin.
When searching for an item, Instead of
Doo Woop (That Thing)
the interface now shows
Lauryn Hill - The Miseducation of Lauryn Hill - Doo Wop (That Thing)
which is arguably clearer, and matches the default output of
beet ls
in the cli.To Do