Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing download of files in non-public mounts #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing download of files in non-public mounts #127

wants to merge 1 commit into from

Conversation

andinger
Copy link

@andinger andinger commented Nov 8, 2019

Currently it's not possible to download files in non-public FAL mounts.
image

This commit fixes the error shown above

@frans-beech-it
Copy link
Contributor

Can you provide the full stacktrace? If I look at the core examples there all controller methods defined in AjaxRoutes.php have ServerRequestInterface $request, ResponseInterface $response as properties

@andinger
Copy link
Author

localhost_8000_typo3_index php_route=%2Fajax%2Ffal_securedownloads%2Fdump_file token=f9002abb83c7be0f996ce6942367631c86ee1a97 eID=dumpFile t=f f=2341 fal_token=be3faf14a817bdf7a113a29b4b29a7af8249c5de (8)

@nilsmehnert
Copy link

It seems neither $request nor $response are used in the controller.
I'd suggest to change it to
public function dumpFile(ServerRequestInterface $request, ResponseInterface $response = null)
to not break the defined methods as frans-beech-it mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andinger @frans-beech-it @nilsmehnert