Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crashing issue when jsYaml.safeload throws an exception #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stjeffrey
Copy link

We had an issue using openapi-comment-parser when some Kubernetes yaml files were in our source folder.
Some of our yamls had '---' which allows us to combine multiple K8s objects in a single file.
After some digging we found the issue to be JSYaml that threw an exception and the parsefile function assumes that if you catch an exception there will be a mark object which isn't the case here.

The code simply checks for e.mark and if it doesn't exist it returns line and column 0 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant