Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move error summary output to stdout #87

Merged
merged 1 commit into from
May 29, 2024

Conversation

davidgumberg
Copy link
Contributor

@davidgumberg davidgumberg commented May 23, 2024

Modifies the summary printed at the end to be entirely in stdout instead of mixed between stderr and stdout. Without this commit, suppressing stdout output or capturing stderr output for logs would result in "The following links could not be resolved:" being printed without the list of broken links (which should be the same as the stderr output.)

For example, on master:

$ ./mlc ~/bitcoin --offline --root-dir ~/bitcoin > /dev/null
[Err ] /home/USER/bitcoin/doc/README_doxygen.md (14, 54) => namespaces.html - Target filename not found.
[Err ] /home/USER/bitcoin/doc/README_doxygen.md (14, 109) => classes.html - Target filename not found.
[Err ] /home/USER/bitcoin/doc/README_doxygen.md (14, 5) => modules.html - Target filename not found.
[Err ] /home/USER/bitcoin/doc/README_doxygen.md (14, 161) => files.html - Target filename not found.
[Err ] /home/USER/bitcoin/test/README.md (335, 19) => /test/functional/blzr - Target not found.
[Err ] /home/USER/bitcoin/src/secp256k1/doc/release-process.md (37, 12) => /tools/check-abi.sh - Target filename not found.

The following links could not be resolved:
$

On this branch:

$ ./mlc ~/bitcoin --offline --root-dir ~/bitcoin > /dev/null
[Err ] /home/USER/bitcoin/src/secp256k1/doc/release-process.md (37, 12) => /tools/check-abi.sh - Target filename not found.
[Err ] /home/USER/bitcoin/test/README.md (335, 19) => /test/functional/blzr - Target not found.
[Err ] /home/USER/bitcoin/doc/README_doxygen.md (14, 54) => namespaces.html - Target filename not found.
[Err ] /home/USER/bitcoin/doc/README_doxygen.md (14, 5) => modules.html - Target filename not found.
[Err ] /home/USER/bitcoin/doc/README_doxygen.md (14, 109) => classes.html - Target filename not found.
[Err ] /home/USER/bitcoin/doc/README_doxygen.md (14, 161) => files.html - Target filename not found.
$ 

Modifies the summary printed at the end to be entirely in stdout
instead of mixed between stderr and stdout. Without this commit,
suppressing stdout output or capturing stderr output for logs would
result in "The following links could not be resolved:" being printed
without the list of broken links (which should be the same as the stderr
output.)
@becheran becheran merged commit a6a9d30 into becheran:master May 29, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants