Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum support #35

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Enum support #35

wants to merge 10 commits into from

Conversation

bbqsrc
Copy link

@bbqsrc bbqsrc commented Mar 17, 2025

Claude was here and the tests all pass. God have mercy on zero or more souls.

@fasterthanlime
Copy link
Contributor

Oooh clippy deny is unhappy

@bbqsrc
Copy link
Author

bbqsrc commented Mar 17, 2025

Not just clippy but also miri. This is enums, there is no god. brb

@bbqsrc
Copy link
Author

bbqsrc commented Mar 17, 2025

okay I have satisfied the pedant

@fasterthanlime
Copy link
Contributor

brendan do you have an opinionated rustfmt config? there's so much whitespace noise in these diffs :(

CleanShot 2025-03-17 at 23 38 20@2x

@bbqsrc
Copy link
Author

bbqsrc commented Mar 17, 2025 via email

@fasterthanlime
Copy link
Contributor

fasterthanlime commented Mar 18, 2025

Nope just the default

One of us is lying, I'll find out who & clean up the whitespace before merging (reader: we're friends, this is just good fun, I'm not being rude to a stranger)

@fasterthanlime fasterthanlime changed the title Enums only a satan could love Enum support Mar 18, 2025
@bbqsrc
Copy link
Author

bbqsrc commented Mar 18, 2025

I have checked with both stable and nightly and it does the same for me.

❯ cargo fmt -v 
[lib (2024)] "/Users/brendan/git/bbqsrc/shapely/shapely/src/lib.rs"
[test (2024)] "/Users/brendan/git/bbqsrc/shapely/shapely/tests/derive.rs"
[lib (2024)] "/Users/brendan/git/bbqsrc/shapely/shapely-core/src/lib.rs"
[proc-macro (2024)] "/Users/brendan/git/bbqsrc/shapely/shapely-derive/src/lib.rs"
[lib (2024)] "/Users/brendan/git/bbqsrc/shapely/shapely-json/src/lib.rs"
[lib (2024)] "/Users/brendan/git/bbqsrc/shapely/shapely-msgpack/src/lib.rs"
[example (2024)] "/Users/brendan/git/bbqsrc/shapely/shapely-pretty/examples/basic_usage.rs"
[lib (2024)] "/Users/brendan/git/bbqsrc/shapely/shapely-pretty/src/lib.rs"
[test (2024)] "/Users/brendan/git/bbqsrc/shapely/shapely-pretty/tests/pretty_print.rs"
[lib (2024)] "/Users/brendan/git/bbqsrc/shapely/shapely-urlencoded/src/lib.rs"
[lib (2024)] "/Users/brendan/git/bbqsrc/shapely/shapely-yaml/src/lib.rs"
rustfmt --edition 2024 /Users/brendan/git/bbqsrc/shapely/shapely/src/lib.rs /Users/brendan/git/bbqsrc/shapely/shapely/tests/derive.rs /Users/brendan/git/bbqsrc/shapely/shapely-core/src/lib.rs /Users/brendan/git/bbqsrc/shapely/shapely-derive/src/lib.rs /Users/brendan/git/bbqsrc/shapely/shapely-json/src/lib.rs /Users/brendan/git/bbqsrc/shapely/shapely-msgpack/src/lib.rs /Users/brendan/git/bbqsrc/shapely/shapely-pretty/examples/basic_usage.rs /Users/brendan/git/bbqsrc/shapely/shapely-pretty/src/lib.rs /Users/brendan/git/bbqsrc/shapely/shapely-pretty/tests/pretty_print.rs /Users/brendan/git/bbqsrc/shapely/shapely-urlencoded/src/lib.rs /Users/brendan/git/bbqsrc/shapely/shapely-yaml/src/lib.rs

@bbqsrc bbqsrc marked this pull request as draft March 19, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants