-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PEP 621 compliant pyproject.toml #38
Use PEP 621 compliant pyproject.toml #38
Conversation
andreasgerstmayr
commented
Jan 26, 2025
- Use PEP 621 compliant pyproject.toml
- Update README to add instructions how to generate the example reports
'scipy >= 1.13.1', | ||
'beanprice >= 1.2.1', | ||
'pandas-stubs >= 2.2.2.240514', | ||
'matplotlib-stubs >= 0.2.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pandas-stubs
and matplotlib-stubs
are required only for type checking, not at runtime, therefore it is not necessary for users to install them. I'll leave these out or I'll add them to a dev
extra dependencies group. My preference would be to leave them out as other development dependencies are not listed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM @dnicolodi I'll merge this quick and try it out though, can be done later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I overlooked this when I converted it from poetry to PEP 621.
I've created a follow-up PR #39 to fix this and also added ruff
and mypy
to the dev dependencies.
Still doesn't work with uv, I think the problem is my pypi auth token. |
That's why I do all releases from CI 🙂 Trusted Publishers remove the need to care about access credentials to PyPI. I recently updated benagulp and beancount to use that. |
I don't know it feels every time I have to use PyPI I have problems |
Found it. Token was buried deep elsewhere.
|
Here's the problem Somehow @dnicolodi you're mentioned on the root cause issue Anyhow, I used the workaround. |
It is a setuptools bug pypa/setuptools#4759. Very recent twine releases have a work around for it. It is however not a bad idea to have setuptools generate valid metadata: add this to
|
I hope they are saying good things 😄 I've been doing some work on the packaging tools recently |
Thank you both! 💯 |