Harden browser auth and related trust boundaries#51
Draft
toimfortes wants to merge 8 commits intobcurts:mainfrom
Draft
Harden browser auth and related trust boundaries#51toimfortes wants to merge 8 commits intobcurts:mainfrom
toimfortes wants to merge 8 commits intobcurts:mainfrom
Conversation
Author
|
Suggested review order for this PR:
Validation run on the branch:
The first commit is the main security boundary change. The rest are narrower follow-up fixes/documentation. |
Author
|
Second hardening pass added two more focused commits:
Branch validation still passes:
|
Author
|
Third pass added one more hardening commit:
Validation still passes:
|
Owner
|
Hi, this is still marked as a work in progress, so it can't be merged, are you ready to submit it yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies a focused hardening pass to a few trust-boundary issues in
agentchattr:HttpOnlysession cookie plus CSRF tokenPOST /api/roles/{agent}/api/open-pathto known local roots instead of arbitrary filesystem pathsWhy
The core issue was trust-boundary collapse:
/api/roleswas unintentionally public because of prefix-based auth bypassThat combination made XSS and local privilege escalation risks much worse than they needed to be.
Validation
Ran successfully:
pytest -qpython -m py_compile app.py run.py archive.py mcp_bridge.py wrapper_api.py tests/test_security_middleware.py tests/test_archive_feature.pynode --check static/chat.jsNotes
I kept the changes intentionally narrow and split into small commits:
The docs are included because these changes affect core security assumptions, not just local deployment preferences.