Skip to content

Conversation

kttkjl
Copy link
Member

@kttkjl kttkjl commented Jul 23, 2025

To be used with API update on this PR

kttkjl added 2 commits July 22, 2025 17:01
  - removed dep props on NavBar
DEVSU-2671
  - fixed some styling, removed unncessary classes
DEVSU-2671
@kttkjl kttkjl self-assigned this Jul 23, 2025
@elewis2 elewis2 requested review from bnguyen-bcgsc and removed request for bnguyen-bcgsc July 23, 2025 15:03
@elewis2
Copy link
Collaborator

elewis2 commented Jul 23, 2025

Getting a red popup when I try to edit my user notifications settings as a user without admin/manager. The settings look updated in the client but the changes don't persist.

@kttkjl kttkjl requested a review from elewis2 July 24, 2025 18:45
Copy link

github-actions bot commented Jul 24, 2025

Test Results

    1 files  ±0    28 suites  ±0   5m 2s ⏱️ +16s
145 tests ±0  145 ✔️ ±0  0 💤 ±0  0 ±0 
142 runs  ±0  142 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit dc3dbbf. ± Comparison against base commit 93e8eca.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@elewis2 elewis2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user profile shows not-set notification settings as set - when opening user profile after failure to set notifications, what's displayed there is not what's in the db

@kttkjl
Copy link
Member Author

kttkjl commented Aug 8, 2025

user profile shows not-set notification settings as set - when opening user profile after failure to set notifications, what's displayed there is not what's in the db

Think the API needs to be updated -- sounds like a permission thing, what exactly are the errors @elewis2 ?

@kttkjl kttkjl added the enhancement New feature or request label Aug 8, 2025
@kttkjl kttkjl requested a review from elewis2 August 11, 2025 22:16
@kttkjl kttkjl merged commit 622d8d6 into develop Aug 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants