Update README.md and fix CI #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lcoombe
commented
Jul 19, 2024
lcoombe
commented
- Add note about lrzip not being available for osx-arm64 conda installs
* Changing clang-format to v18 * With the existing clang, I was getting very odd errors, such as not being able to find the system headers * I had to add more ignores with this update - we can go back and look at those in more detail if desired * On linux, code coverage wasn't working with the newest meson - I decided to just move that test and use meson 1.4.0 for it only * There were other issues for the clang and code coverage checks for mac, but I decided to remove those, since we are covering code quality with linux anyway * Fixes for clang-format * Remove last column from large.bam - was causing issues for ninja sanitize-undefined in mac
|
Changes needed for CI:
|
jwcodee
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.