Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CBFs for true counts in ntHits #119

Merged
merged 7 commits into from
Apr 6, 2024
Merged

Update CBFs for true counts in ntHits #119

merged 7 commits into from
Apr 6, 2024

Conversation

parham-k
Copy link
Member

@parham-k parham-k commented Apr 5, 2024

Added a parameter in CBF's insert function to determine the increment value.

@parham-k parham-k requested review from lcoombe and jwcodee April 5, 2024 16:18
lcoombe
lcoombe approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@lcoombe lcoombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Will we also have to update the documentation for the optional increment parameter with the CBF?

@parham-k
Copy link
Member Author

parham-k commented Apr 5, 2024

Thank you! Yes, I will update the docs before merging.

@parham-k parham-k merged commit cc2581f into master Apr 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcoombe lcoombe lcoombe approved these changes

@jwcodee jwcodee Awaiting requested review from jwcodee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parham-k @lcoombe