Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate Phred Average #104

Merged
merged 16 commits into from
Jul 5, 2023
Merged

Calculate Phred Average #104

merged 16 commits into from
Jul 5, 2023

Conversation

jwcodee
Copy link
Member

@jwcodee jwcodee commented Jul 5, 2023

This PR contains the utility to calculate the Phred average given a string, a utility that we found pretty useful throughout the development of GoldRush. Once the changes are finalized, I will update the docs and generate the wrappers.

@jwcodee jwcodee requested review from vlad0x00, lcoombe and parham-k July 5, 2023 05:21
Copy link
Member

@lcoombe lcoombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Johnathan! Just a couple small comments from me.

Copy link
Member

@lcoombe lcoombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Johnathan!

@jwcodee jwcodee merged commit d1810e1 into master Jul 5, 2023
@jwcodee jwcodee deleted the calc_phred_avg branch July 5, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants