Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency ubuntu to v24 #134

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 26, 2024

This PR contains the following updates:

Package Type Update Change
ubuntu github-runner major 22.04 -> 24.04

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@conbrad
Copy link
Collaborator

conbrad commented Sep 26, 2024

Does Github support v24 yet?

@conbrad
Copy link
Collaborator

conbrad commented Sep 26, 2024

Looks like they're still rolling it out: actions/runner-images#10636

@conbrad
Copy link
Collaborator

conbrad commented Sep 26, 2024

@DerekRoberts
Copy link
Member

@conbrad Hope so! We're seeing some inconsistent results around oc being missing in this update too.

@mishraomp
Copy link

@conbrad Hope so! We're seeing some inconsistent results around oc being missing in this update too.

Agreed,
https://github.com/bcgov/nr-oracle-service/actions/runs/11058509723/job/30724923103
cc @conbrad @DerekRoberts

@conbrad
Copy link
Collaborator

conbrad commented Sep 26, 2024

@conbrad Hope so! We're seeing some inconsistent results around oc being missing in this update too.

Agreed, https://github.com/bcgov/nr-oracle-service/actions/runs/11058509723/job/30724923103 cc @conbrad @DerekRoberts

There's a lot of complaints in the thread (actions/runner-images#10636) regarding removed dependencies

@conbrad
Copy link
Collaborator

conbrad commented Sep 26, 2024

@conbrad Hope so! We're seeing some inconsistent results around oc being missing in this update too.

Agreed, https://github.com/bcgov/nr-oracle-service/actions/runs/11058509723/job/30724923103 cc @conbrad @DerekRoberts

There's a lot of complaints in the thread (actions/runner-images#10636) regarding removed dependencies

Ah yes, they've removed openshift cli:

OpenShift CLI latest available - Removed from the Ubuntu 24.04 image due to maintenance reasons.

@mishraomp
Copy link

@conbrad Hope so! We're seeing some inconsistent results around oc being missing in this update too.

Agreed, https://github.com/bcgov/nr-oracle-service/actions/runs/11058509723/job/30724923103 cc @conbrad @DerekRoberts

There's a lot of complaints in the thread (actions/runner-images#10636) regarding removed dependencies

Ah yes, they've removed openshift cli:

OpenShift CLI latest available - Removed from the Ubuntu 24.04 image due to maintenance reasons.

oh no

@DerekRoberts
Copy link
Member

@conbrad @mishraomp That's fine! We have examples for pulling in oc. We can look at using kubectl more too.

@mishraomp
Copy link

@conbrad @mishraomp That's fine! We have examples for pulling in oc. We can look at using kubectl more too.

can we create a github hosted runner, and share it with all the bells whistles we need

@DerekRoberts
Copy link
Member

We have to decide on a whole new container vs importing oc every time it's needed. For Actions this is fine, just a one off. For odd jobs it's more of a nuissance. ...How about a setupoc Action? Should be a lot like node and other patterns.

@conbrad
Copy link
Collaborator

conbrad commented Sep 26, 2024

We have to decide on a whole new container vs importing oc every time it's needed. For Actions this is fine, just a one off. For odd jobs it's more of a nuissance. ...How about a setupoc Action? Should be a lot like node and other patterns.

I like the action approach, a bit more self contained. Any drawbacks?

@mishraomp
Copy link

We have to decide on a whole new container vs importing oc every time it's needed. For Actions this is fine, just a one off. For odd jobs it's more of a nuissance. ...How about a setupoc Action? Should be a lot like node and other patterns.

I like the action approach, a bit more self contained. Any drawbacks?

I like it too, so that we can parameterize the version specific to silver, gold, et.. and teams not to worry about version management, though they can explicitly provide a version if they would like to, lets do it

@DerekRoberts
Copy link
Member

@paulushcgcj pointed out one already exists! I'll put that in at least our deployer action. There'll be lots of other cases. @conbrad @mishraomp

https://github.com/marketplace/actions/openshift-tools-installer

@DerekRoberts
Copy link
Member

Looks life Renovate itself is fine, so let's get this merged!

@renovate renovate bot merged commit 5bd2b09 into main Sep 26, 2024
2 checks passed
@renovate renovate bot deleted the renovate/major-github-actions-all branch September 26, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants