Fix HRIA Discontinued Data Details Page #1157
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bferguso
requested changes
Jan 13, 2026
Collaborator
bferguso
left a comment
bferguso
left a comment
There was a problem hiding this comment.
Overall looks good, but I think we should make that field datatype match the other "modified by" fields in that resource model.
| other_maps_modified_by: ResourceInstanceListValue; // resource-instance-list (contributor) | ||
| other_maps_map_name: StringValue; | ||
| other_maps_map_scale: StringValue; | ||
| other_maps_modified_by: ResourceInstanceListValue; |
Collaborator
There was a problem hiding this comment.
I think this should be a StringValue not ResourceInstanceListValue based on the graph datatype. Wondering if we should make this non-localized string datatype to match the other "modified_by" values in that resource model.
| "searchDsl": "", | ||
| "searchString": "" | ||
| }, | ||
| "datatype": "string", |
Collaborator
There was a problem hiding this comment.
Wondering if this should be a non-localized-string to match the other fields in this model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses and fixes issues from first attempt raised in #1140
closes #1140