SIMSBIOHUB-540/528: Pipeline Enhancements #1204
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1204 +/- ##
=======================================
Coverage 56.43% 56.43%
=======================================
Files 576 576
Lines 17626 17626
Branches 2745 2745
=======================================
Hits 9948 9948
Misses 7014 7014
Partials 664 664 ☔ View full report in Codecov by Sentry. |
curtisupshall
previously approved these changes
Mar 19, 2024
curtisupshall
previously approved these changes
Mar 19, 2024
|
NickPhura
added
Early Feedback Welcome
NickPhura
removed
the
Early Feedback Welcome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May hold off on merging this until after we go to Prod, just to ensure the initial prod release works without issue under the old pipeline, which we know works.
Links to Jira Tickets
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-540
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-528
Description of Changes
Moving pipeline config settings into OpenShift config map, so they aren't hard-coded in the repo. Will allow env var changes to be made without needing to commit anything to the repo.
Testing Notes
The pipeline deploys, and all previous functionality works as expected.