Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate append coordinates #52

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Validate append coordinates #52

merged 4 commits into from
Feb 8, 2024

Conversation

forman
Copy link
Member

@forman forman commented Feb 5, 2024

  • A new configuration setting append_step can be used to validate the step sizes between the labels of a coordinate variable associated with the append dimension. Its value can be a number for numerical labels or a time delta value of the form 8h (8 hours) or 2D (two days) for date/time labels. The value can also be negative.

  • The configuration setting append_step can take the special values "+" and "-" which are used to verify that the labels are monotonically increasing or decreasing.

Closes #20
Closes #21

@forman forman requested a review from pont-us February 5, 2024 17:42
@forman
Copy link
Member Author

forman commented Feb 5, 2024

@pont-us, please add @clarasb as reviewer

@forman forman marked this pull request as ready for review February 5, 2024 17:44
@forman forman self-assigned this Feb 5, 2024
@forman forman added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee28dee) 99.82% compared to head (52da874) 99.83%.

❗ Current head 52da874 differs from pull request most recent head cc6303f. Consider uploading reports for the commit cc6303f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   99.82%   99.83%           
=======================================
  Files          25       25           
  Lines        1149     1208   +59     
=======================================
+ Hits         1147     1206   +59     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman requested review from clarasb and removed request for pont-us February 8, 2024 11:40
Copy link
Collaborator

@clarasb clarasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote you some comments.

@forman forman merged commit 83e70f6 into main Feb 8, 2024
3 checks passed
@forman forman deleted the forman-21-append_step branch February 8, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
2 participants