Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: react bootstrap #49

Draft
wants to merge 17 commits into
base: bbc-release53
Choose a base branch
from
Draft

wip: react bootstrap #49

wants to merge 17 commits into from

Conversation

Julusian
Copy link
Collaborator

@Julusian Julusian commented Feb 19, 2025

This is a 'from scratch' rebuild of the css/styling using react-bootstrap instead of origo.

The approach being taken is to remove all existing css, then work through each page/section and fixup styles to bootstrap. some old custom css is disabled, to ensure it doesn't conflict with new bootstrap code.
While doing this, a quick review of the custom css is being done, to check for any obvious dead code.

Not aiming for pixel perfect in most pages/areas, I am embracing that bootstrap wants to use slightly different numbers for its margins, and has slightly different style rules (rounded corners etc). The aim is for it to feel like the same software, even if things have shifted slightly.
The exception being pages like the rundownView, where the bulk of it should be a pixel perfect match.

Some bits where it doesnt look like bootstrap has a suitable equivalent has been copied into our code.

For testing this, clone and run as usual. I recommend also running just the webui from the base branch in parallel. Doing a yarn dev in the webui package will result in vite picking the next available port (3006), and will proxy connections to the same meteor backend. This allows for easy side by side comparisons of the exact same state.

So far I have tackled:

  • settings
  • started on rundown view

Skipped pages:

  • message queue
  • evaluations table (but markup looks the same as elsewhere)
  • media status content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant