feat: time of day pieces #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julusian
force-pushed
the
feat/time-of-day-pieces
branch
from
da6c1b5 to
9f6afb7
Compare
Julusian
force-pushed
the
feat/time-of-day-pieces
branch
from
3096a98 to
c01f9b8
Compare
Julusian
force-pushed
the
feat/time-of-day-pieces
branch
2 times, most recently
from
43f94cd to
1e3735e
Compare
Julusian
force-pushed
the
feat/time-of-day-pieces
branch
from
1e3735e to
5023596
Compare
mint-dewit
reviewed
Feb 14, 2025
| @@ -221,7 +221,7 @@ export function useSelectedElements( | |||
| const computation = Tracker.nonreactive(() => | |||
| Tracker.autorun(() => { | |||
| const piece = Pieces.findOne(selectedElement?.elementId) | |||
| const part = UIParts.findOne({ _id: piece ? piece.startPartId : selectedElement?.elementId }) | |||
| const part = UIParts.findOne({ _id: piece?.startPartId ? piece.startPartId : selectedElement?.elementId }) | |||
There was a problem hiding this comment.
I think this could be simplified
Suggested change
| const part = UIParts.findOne({ _id: piece?.startPartId ? piece.startPartId : selectedElement?.elementId }) | |
| const part = UIParts.findOne({ _id: piece?.startPartId ?? selectedElement?.elementId }) |
| enable: { | ||
| start: regenerateTimelineAt, | ||
| }, | ||
| layer: '__timeline_regeneration_trigger__', // Some unique name, as callbacks need to be on a layer |
There was a problem hiding this comment.
Perhaps we should collect layer names like this somewhere and document them? Although I have my doubts about anyone ever finding that documentation
| } | ||
|
|
||
| // /** Whether and how the piece is infinite */ | ||
| // lifespan: PieceLifespan |
There was a problem hiding this comment.
Possibly to be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.