New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODO block from getBaseUrl/index.js #9822

Closed

joshcoventry wants to merge 1 commit into latest from remove_getbaseurl_todo

Contributor

joshcoventry commented Jan 26, 2022

No Git issue. Removes a TODO block that was left in which was supposed to be removed before a PR was merged some time ago.

Overall change:

Removes a TODO block that was used for testing

Code changes:

Removed a block from getBaseUrl/index.js

I have assigned myself to this PR and the corresponding issues
I have added the cross-team label to this PR if it requires visibility across World Service teams
I have assigned this PR to the Simorgh project
(BBC contributors only) This PR follows the repository use guidelines

Testing:

Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)
This PR requires manual testing


          Remove TODO block from getBaseUrl/index.js

b99865c

joshcoventry closed this

joshcoventry deleted the remove_getbaseurl_todo branch

January 26, 2022 12:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet