Tests for all pages #13222
Tests for all pages #13222
Conversation
…TestsForAllPages
…TestsForAllPages
…TestsForAllPages
karinathomasbbc
changed the base branch from
latest
to
RefactorTestsForAllPages
| tests, | ||
| }, | ||
| { | ||
| path: '/kyrgyz', |
There was a problem hiding this comment.
Removed as there are multiple images without alt text
| service: '/serbian/cyr', | ||
| tests, | ||
| }, | ||
| { |
There was a problem hiding this comment.
As above, multiple images without alt text, but we already have serbian as the service with variant, so can live without these tests
| checkA11y(); | ||
| }); | ||
|
|
||
| it('should render topic tags if they are in the json, and they should navigate to correct topic page', () => { |
There was a problem hiding this comment.
Related topics only exist on Article + Media Article pages, so have moved it to the respective test pages
| item => | ||
| !item.parentNode.closest( | ||
| 'section[data-testid="portrait-video-carousel"]', | ||
| ), |
There was a problem hiding this comment.
I should probably annotate this in the code, but for now, the PV carousel icons are jpgs not webp.
There was a problem hiding this comment.
Updated fixture data so that all images are webp
| <section | ||
| role="region" | ||
| aria-labelledby="bbcMediaPlayer0" | ||
| aria-labelledby={`bbcMediaPlayer${nthCurationByStyleAndProminence - 1}`} |
There was a problem hiding this comment.
This is to fix an issue on the localhost:7080/dari page which has 2 media players.
2 participants
Resolves JIRA:
Summary
A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.
Code changes
Developer Checklist
Testing
Ready-For-Test, Local)Ready-For-Test, Test)Ready-For-Test, Preview)Ready-For-Test, Live)Additional Testing Steps
Useful Links