Add new custom variable 'projectile-cmd-hist-ignoredups' #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurenceWarne
force-pushed
the
add-custom-varaible-for-deduping-cmd-history
branch
2 times, most recently
from
ba69dde
to
fee1ae7
Compare
|
The proposed change is fine by me. Might be a good idea to mention this configuration option somewhere in the docs as well, otherwise I doubt many people will find it. |
bbatsov
reviewed
Jan 22, 2024
| A value of t means consecutive duplicates are ignored. | ||
| A value of `erase' means only the last duplicate is kept. | ||
| A value of nil means nothing is ignored." | ||
| :type '(choice (const :tag "Don't ignore anything" nil) |
There was a problem hiding this comment.
Don't forget to add a :package-version property here.
Add new custom variable 'projectile-cmd-hist-ignoredups', which can be used to tweak how duplicates are dealt with in projectile's command history. The custom variable is identical in behaviour to 'eshell-hist-ignoredups'. Specifically, the existing default behavior is maintained with the value of t, which means consecutive duplicates are ignored. A value of 'erase means only the last duplicate is kept, whilst a value of nil means all duplicates are kept.
LaurenceWarne
force-pushed
the
add-custom-varaible-for-deduping-cmd-history
branch
from
fee1ae7
to
6d9cd66
Compare
Makes sense, let me know if the section I've added it looks appropriate. |
|
Looks great! Thanks! |
|
Thanks! |
LaurenceWarne
deleted the
add-custom-varaible-for-deduping-cmd-history
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR adds new custom variable
projectile-cmd-hist-ignoredups, which can be used to tweak how duplicates are dealt with in projectile's command history. The custom variable is more or less identical in behaviour toeshell-hist-ignoredups.Specifically, the existing default behavior is maintained with the value of
t, which means consecutive duplicates are ignored. A value of'erasemeans only the last duplicate is kept, whilst a value ofnilmeans all duplicates are kept.(PR is an iteration on #1774)
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)M-x checkdocwarningsThanks!