Fix Git submodule command on Windows #1764
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projectile produces an error when finding project files in a Git repository with submodules on Windows (#1600). This is because the command to find the submodules is hard-coded, including the quotes. This PR adds a
projectile-get-git-sub-projects-command
function to generate the command with the correct quoting at runtime. It also addsprojectile-git-submodule-command-function
, which is set toprojectile-get-git-sub-projects-command
by default, obsoletingprojectile-git-submodule-command
.I’m not sure I can add tests for this since it’s specific to the combination of Git, submodules, and Windows. I did run
checkdoc
but it showed a whole lot of unrelated errors.Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test
)M-x checkdoc
warningsYou've updated the readme (if adding/changing user-visible functionality)Thanks!