Architectural Changes #82
Conversation
|
Thanks for you interest in the project! |
| FileUtils.createDirectory(fileNames.getWorkingDir()); | ||
| } | ||
| System.out.println(); | ||
| System.out.println("CHRIS CONNOLLY RUNNING THIS"); |
There was a problem hiding this comment.
I guess you forgot to remove this?
There was a problem hiding this comment.
Yep, sorry. Apologies for my naivety but once I've made the changes in my forked repo, do I need to submit another PR or does this one auto update?
There was a problem hiding this comment.
Just push a new commit to the same branch and it will magically be added to your PR :-)
There was a problem hiding this comment.
"the same branch" = master for you. By the way, the usual workflow in open source is this: 1) Post an issue describing a specific problem and how you will solve it 2) Create a branch with a name that refers to this issue and fixes only that specific issue 3) Send pull request. You can do this for several issues in parallel, and the maintainers can decide what issues are real issues or non-issues, and prioritize what branch to review and pull first.
Cheers!
There was a problem hiding this comment.
Thanks for that information. I've dealt with issues on Kanban boards etc but working with open source is new to me :) Cheers!
|
Yeah sorry about that. I didn't actually think I was going to make a PR when I did the project but I figured I may as-well. Sorry for the extra work that will require. |
|
Might I recommend when considering this that you go to 'diff settings' and 'hide whitespace changes'. This should make the review process a lot easier to view. |
Hello,
As part of one of my papers at University we were asked to select an open source project to improve. I decided on yours. Apologies for the size of the changes. I've added some documentation here in the 'what I've changed' folder to try explain things a bit better.
Essentially my changes were about redesigning the system to be more flexible and extensible in case of future requirements change. It should make the usage of the command line much simpler while still working in the same way. It also 'fails faster' by adding much better validation on the command line arguments, and also begins to use more design patterns.
I'm not saying my changes are incredible, lord knows they're not - I'm still at uni for peats sake, but this is my first pull request so that's exciting!
Thanks :)