Changes related to issue #79 deadlinks #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Apr 27, 2018
| poi.add(ValidationIssue.INVALID_URL); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private boolean validWebsiteURL(String urlString) { | ||
| public boolean urlExists(String urlString) { |
There was a problem hiding this comment.
Could you please add this:
if (urlString.contains("{{dead link")) {
return false;
}
Thanks! :-)
|
Also, broken URL should be thrown away and not put into the output data. This can be a different pull request. |
|
Well anyways removing broken URL is been already handled previously i guess. I dint find it in any other place |
| @Test | ||
| public void testURLExistPositive(){ | ||
| WebsiteURLValidator websiteURLValidator = new WebsiteURLValidator(); | ||
| assertTrue(websiteURLValidator.urlExists("www.google.com")); |
There was a problem hiding this comment.
I think we should require a protocol (for instance https://) no?
| url = new URL(urlString); | ||
|
|
||
| // We want to check the current URL | ||
| HttpURLConnection.setFollowRedirects(false); |
There was a problem hiding this comment.
Indentation seems to be inconsistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.