Additional Validations - URL and Lat-Long validation improvements

[dazyoung]

A few updates have been made to the validations.

1. I noticed that some URLs which were working, were still not valid. This was caused by non standard characters appearing in the host name which breaks with the RFC2396 which java.net.URL uses.
2. Related to Convert German coordinates from 7°48'31.0"-like format to decimal #41 , I have added some validation checks on both decimal and DMS (e.g. 17°38'15.60"E) style coordinates. The DMS style coordinates are validated when the input is not a float value and conforms to a regex which I have defined. The regex is probably not flawless but covers all cases which I threw at it as well as not letting extra stuff through.

[dazyoung]

@nicolas-raoul debating where would be best to make this update.
As far as I can see, the two viable points are:

1. at the point of reading (i.e. when constructing the listing in German.java).
2. after reading, when outputting to the various output formats.

The advantage of Option 1 would be that we don't make totally unnecessary checks (e.g. is the lat-long in DMS or Decimal format). Basically, a consistent way of handling the data right through the process

The advantage of Option 2 would be that data gets to work it's way through the validation process as before. Option 1 has the disadvantage of effectively short-circuiting out invalid entries before the validation process takes place. We would however need to check the format each time on output to determine where conversions were necessary however by this point.

Any thoughts on this would be appreciated, it is not a difficult issue to resolve, but undecided on where the most appropriate place would be to perform this conversion.

[nicolas-raoul]

I am for option 1 I would say. How about creating a validation data object and passing it to Language.java?

[nicolas-raoul]

Hi @darrenyoung89 !
We have changed how validation works (see commit 7d2abc7), so now it should be quite straightforward for you to put validation at the right place :-)
Cheers!