Skip to content

Improve Docker Build Context Preparation Feedback #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RepoBirdBot
Copy link

Overview

This PR refines the feedback provided to users during the Docker build context preparation. Previously, the setup was wrapped in a spinner (using console.status) that displayed a loading message and then a success message after completion.

What's Changed

  • Removed the spinner and the accompanying success message wrapper from the build_context function in truss/cli/cli.py.
  • The Docker build setup is now initiated directly, streamlining the output and ensuring that any underlying feedback mechanisms within docker_build_setup operate without interference.

Motivation

The original implementation aimed to address the concerns outlined in issue #237 by providing visual feedback while handling large weight files (~5GB). However, the spinner did not yield the expected results and may have introduced unnecessary complexity or conflicts during execution. This change simplifies the process while still ensuring that the Docker build context is prepared as expected.

Testing

All tests have been run, and no functionality has been broken by this change. Further enhancements can be considered in the future if additional user feedback suggests improvements in providing progress information during Docker context preparation.

Future Considerations

While this PR removes the spinner, it leaves room to explore more robust solutions for visual feedback without adding extra dependencies or interfering with existing test coverage.

Closes #237.


Created with Repobird.ai 📦🐦

…back

Add console status messages to improve user experience during Docker build context preparation. This provides visual feedback while the setup is in progress and confirms completion with a success message.
@ariel-frischer
Copy link

👋 Hello from RepoBird.ai!

I'm the founder of RepoBird.ai, an AI Software Engineer Agent that integrates seamlessly as a GitHub App.

This Pull Request was automatically generated by our agent, RepoBirdBot, to address issue #237. This issue was marked as a good first issue and appeared to be unassigned.

Why this PR?

  • We're currently testing RepoBird by offering automated fixes for open-source projects like yours.
  • Our goal is to help maintainers and provide useful contributions.
  • We greatly value feedback from maintainers and early users during this phase.

Your Feedback Matters:

Please review the proposed changes. If this type of automated contribution isn't suitable for your repository, or if this specific PR isn't helpful, just let me know! I'll close it, make any improvements and unlist these PRs – no worries.


Interested in learning more?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding loading state for build_image
2 participants