Improve Docker Build Context Preparation Feedback #1613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refines the feedback provided to users during the Docker build context preparation. Previously, the setup was wrapped in a spinner (using
console.status
) that displayed a loading message and then a success message after completion.What's Changed
build_context
function intruss/cli/cli.py
.docker_build_setup
operate without interference.Motivation
The original implementation aimed to address the concerns outlined in issue #237 by providing visual feedback while handling large weight files (~5GB). However, the spinner did not yield the expected results and may have introduced unnecessary complexity or conflicts during execution. This change simplifies the process while still ensuring that the Docker build context is prepared as expected.
Testing
All tests have been run, and no functionality has been broken by this change. Further enhancements can be considered in the future if additional user feedback suggests improvements in providing progress information during Docker context preparation.
Future Considerations
While this PR removes the spinner, it leaves room to explore more robust solutions for visual feedback without adding extra dependencies or interfering with existing test coverage.
Closes #237.
Created with Repobird.ai 📦🐦