Add support for '--preserve-env-instance-type' option to chains push #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marius-baseten
approved these changes
Apr 17, 2025
| is_flag=True, | ||
| required=False, | ||
| default=None, | ||
| help=( |
There was a problem hiding this comment.
Since this is a long description and might be rephrased in the future, you could introduce a variable and re-use it for both chains/truss (formulating it in a neutral way).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 What
Adding support for the
--preserve-env-instance-type/--no-preserve-env-instance-typeflags to the chains CLI.Also introduce aliases for the flags for both chains and trusses to make help text more readable
💻 How
Add CLI option and wire it to baseten API call
🔬 Testing
Tested locally and ran unit tests