Open
Conversation
bolasim
reviewed
Jul 1, 2024
Comment on lines
+1
to
+3
| base_image: | ||
| image: nvcr.io/nvidia/pytorch:23.11-py3 | ||
| python_executable_path: /usr/bin/python3 |
Contributor
There was a problem hiding this comment.
just cuious why we need this base image? Can you add a cooment?
Contributor
Author
There was a problem hiding this comment.
Without this base image the build does not succeed. The baseten base image does not have nvcc, which is required for the developer build of vLLM.
| tensor_parallel: 1 | ||
| max_num_seqs: 16 | ||
| model_name: vLLM Speculative Decoding | ||
| python_version: py310 |
Contributor
There was a problem hiding this comment.
drop python version if using base image
| python_executable_path: /usr/bin/python3 | ||
| build_commands: [] | ||
| environment_variables: | ||
| HF_TOKEN: "" |
Contributor
Author
There was a problem hiding this comment.
vLLM reads only this specific environment variable for the access token. It doesn't work with secrets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.