Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple TLS domains #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support multiple TLS domains #28

wants to merge 2 commits into from

Conversation

hasghari
Copy link

@hasghari hasghari commented May 6, 2024 •
edited

Fixes #26

Allow the TLS_DOMAIN environment variable to be specified as a comma-separated list to support multiple domains

@hasghari hasghari mentioned this pull request May 6, 2024
Open
3v0k4
3v0k4 reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@3v0k4 3v0k4 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on how I would have approached it. Feel free to ignore 🙂

Good job!

EDIT: Remember to add this change to the changelog.

internal/server.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3v0k4 3v0k4 3v0k4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple TLS domains
3 participants
@hasghari @3v0k4 @kevinmcconnell