adding e2e tests for basenames registration flow #2489

Aushveen · 2025-06-26T20:44:44Z

This is a E2E test using the newly released npm package @coinbase/onchaintestkit

This tests the registration flow, specifically:

A successful registration
A failed one if the user rejects the transaction
A basic wallet connect test
A failed one if user wallet lacks funds

This is built with playwright, anvil ETH nodes, and foundry

vercel · 2025-06-26T20:44:48Z

@Aushveen is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

cb-heimdall · 2025-06-26T20:44:49Z

✅ Heimdall Review Status

Requirement Status More Info

Reviews

✅ 1/1

Denominator calculation

Show calculation

1 if user is bot 0

1 if user is external 0

2 if repo is sensitive 0

From .codeflow.yml 1

Additional review requirements

Show calculation

Max	0

0

From CODEOWNERS 0

Global minimum 0

Max 1

1

1 if commit is unverified 0

Sum 1

cb-heimdall · 2025-06-30T18:44:13Z

Review Error for timothywangdev-cb @ 2025-06-30 18:44:13 UTC
User must have write permissions to review

timothywangdev-cb · 2025-06-30T18:44:30Z

LGTM

arjun-dureja · 2025-06-30T19:20:58Z

apps/web/e2e/tests/connectWallet.spec.ts

+    if (!metamask) {
+      throw new Error('Metamask is not defined');
+    }


Does every test we write need this? Is there a way we can make onchaintestkit perform this check for us?

yes, this is required. Since OCTK only provides the components for the tests, it’s not possible to do it directly. Users have to create their wallet through wallet manager

this should not be an issue anyways since when you import test from testFixture, it has the metamask set up there.

arjun-dureja · 2025-06-30T19:22:00Z

.github/workflows/e2e-tests.yml

+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]


Does this make it required to pass before we can merge?

yes, that's the goal right. It is an e2e test to make sure the registry flow works as intended. If anything changes, such as the UI components, then the E2E tests should be changed accordingly.

apps/web/e2e/E2Ereadme.md

arjun-dureja · 2025-06-30T19:24:29Z

apps/web/e2e/E2Ereadme.md

+
+---
+
+## Running the tests locally


Could there also be instructions on how to run this with headless mode disabled so that you can see the test running?

resolved, check lines below

arjun-dureja · 2025-06-30T19:25:18Z

apps/web/e2e/E2Ereadme.md

+Aushveen Vimalathas
+:no_bell:  Today at 10:51 AM


Suggested change

Aushveen Vimalathas

:no_bell: Today at 10:51 AM

arjun-dureja · 2025-06-30T19:25:48Z

apps/web/e2e/E2Ereadme.md

+Error: Timed out waiting 60000ms from config.webServer.
+```
+
+Try re-running the E2E workflow a couple more times


What causes this to happen?

it happens in the workflows, loading the web browser/ui in the workflow takes a super long time. I will double this value

stevieraykatz · 2025-06-30T20:00:14Z

apps/web/e2e/tests/registration-success.spec.ts

+    // Complete registration
+    await initiateRegistration(mainPage);
+    await page.waitForLoadState('networkidle');
+    await handleTransaction(metamask);


Can we check that the balance of the test account was decremented by the expected cost?

not at the moment, we could add a method though that will get the balance of the wallet in the future upgrades to onchaintestkit

The way the approve transaction works is that it only gets approved if the wallet has sufficient funds.

Co-authored-by: Arjun Dureja <[email protected]>

…se breaks

arjun-dureja · 2025-07-01T17:27:36Z

apps/web/app/(basenames)/api/proofs/baseEthHolders/route.ts

+    if (process.env.E2E_TEST !== 'true') {
+      logger.error('error getting proofs for baseEthHolders', error);
+    }


Is there a way to prevent needing to do this? It would be very easy to forget to add this check when writing future API routes.

Maybe the check can be added in the error function itself? https://github.com/base/web/blob/master/apps/web/src/utils/logger.ts#L80

apps/web/next.config.js

vercel · 2025-07-01T18:24:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
base-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 1, 2025 6:27pm

Aushveen had a problem deploying to CI June 26, 2025 20:48 — with GitHub Actions Failure

Aushveen force-pushed the BaseWeb/RegistrationFlow/E2ETests branch from 1f77c99 to cf6083e Compare June 26, 2025 22:00

Aushveen had a problem deploying to CI June 26, 2025 22:10 — with GitHub Actions Failure

Aushveen force-pushed the BaseWeb/RegistrationFlow/E2ETests branch from cf6083e to 6e8fd7a Compare June 27, 2025 15:47

Aushveen had a problem deploying to CI June 27, 2025 15:53 — with GitHub Actions Failure

Aushveen force-pushed the BaseWeb/RegistrationFlow/E2ETests branch 2 times, most recently from 7c12e05 to 2715d2e Compare June 27, 2025 16:37

Aushveen had a problem deploying to CI June 27, 2025 17:02 — with GitHub Actions Failure

Aushveen force-pushed the BaseWeb/RegistrationFlow/E2ETests branch from 2715d2e to 23b5df9 Compare June 27, 2025 17:34

Aushveen had a problem deploying to CI June 27, 2025 17:47 — with GitHub Actions Failure

Aushveen force-pushed the BaseWeb/RegistrationFlow/E2ETests branch 15 times, most recently from d0e1863 to 324f177 Compare June 28, 2025 03:12

timothywangdev-cb approved these changes Jun 30, 2025

View reviewed changes

arjun-dureja reviewed Jun 30, 2025

View reviewed changes

stevieraykatz reviewed Jun 30, 2025

View reviewed changes

Aushveen force-pushed the BaseWeb/RegistrationFlow/E2ETests branch 4 times, most recently from 3871f74 to 82de660 Compare July 1, 2025 01:03

Aushveen and others added 5 commits June 30, 2025 18:26

adding e2e tests for basenames registration flow

0fe314e

Update apps/web/e2e/E2Ereadme.md

fadf091

Co-authored-by: Arjun Dureja <[email protected]>

apply fixes

2220d77

adding failed test due to no funds

f7affda

testing fix for routing

b83c422

Aushveen force-pushed the BaseWeb/RegistrationFlow/E2ETests branch from 9238fa5 to b83c422 Compare July 1, 2025 01:27

debugging further

d0feaa3

Aushveen force-pushed the BaseWeb/RegistrationFlow/E2ETests branch from 34d20ea to d0feaa3 Compare July 1, 2025 02:14

testing new configs for more debugging, revert to prev step if all el…

ecf4f3c

…se breaks

Aushveen force-pushed the BaseWeb/RegistrationFlow/E2ETests branch from 9381e16 to ecf4f3c Compare July 1, 2025 03:07

e2e test for fail spec worked before this commit, testing smth new

7f90fa5

Aushveen force-pushed the BaseWeb/RegistrationFlow/E2ETests branch from 4661202 to 9b203b9 Compare July 1, 2025 03:59

test b4 worked for failed register, testing all at once now

4a1fd11

Aushveen force-pushed the BaseWeb/RegistrationFlow/E2ETests branch from 9b203b9 to 4a1fd11 Compare July 1, 2025 04:24

update readme

68ebb07

arjun-dureja reviewed Jul 1, 2025

View reviewed changes

updating logger.ts

85af792

vercel bot deployed to Preview July 1, 2025 18:27 View deployment

arjun-dureja approved these changes Jul 1, 2025

View reviewed changes

Aushveen merged commit f9d3ea3 into base:master Jul 1, 2025
7 checks passed

adding e2e tests for basenames registration flow #2489

adding e2e tests for basenames registration flow #2489

Uh oh!

Conversation

Aushveen commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jun 26, 2025

Uh oh!

cb-heimdall commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Heimdall Review Status

Uh oh!

cb-heimdall commented Jun 30, 2025

Uh oh!

timothywangdev-cb commented Jun 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aushveen Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vercel bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Aushveen commented Jun 26, 2025 •

edited

Loading

cb-heimdall commented Jun 26, 2025 •

edited

Loading

Aushveen Jun 30, 2025 •

edited

Loading

vercel bot commented Jul 1, 2025 •

edited

Loading