Skip to content

Added support for Zsh #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

brianmatzelle
Copy link

Hi! I found this to be useful, so I converted the bash script to zsh and added supporting tests + documentation for it.

I duplicated the bash documentation into zsh sections, rather than merging instructions. I figured it would be best for you to decide what direction to take the documentation in, so I tried not to only add -- not edit/remove anything.

If you merge the fork, make sure to change the links called by the curl request right after merging. They're currently pointing to my fork, but should point to the main repo afterwards.

@brianmatzelle
Copy link
Author

brianmatzelle commented Oct 16, 2024

One question, was it intentional to have the shell exit into nothingness after leaving the directory with .local.bashrc in it?

I'd prefer if it returned back to the parent shell after exiting, so I altered the script on my local machine to do that. I didn't merge it because I'm not sure if you intentionally detached the .local shell. I don't want to disrespect/alter any design choices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant