fix(alerts): use correct businessIds to seed transaction alerts #2727

[kmanikanta335]

Replace businessRiskIds with businessIds
Incorrect businessRiskIds were used when seeding transaction alerts, causing issues as they didn't exist at the time of adding alerts. Fixed by using the correct businessIds."

Summary by CodeRabbit

• Bug Fixes
  • Corrected the business data used during transaction alert generation to ensure users receive accurate and consistent alert information.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3026788

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

This pull request updates the seedTransactionsAlerts function in the seed.ts file. The parameter passed for business identifiers has been changed from businessRiskIds to businessIds, affecting which identifiers are used during the seeding process. No other modifications or logic changes are present.

Changes

File(s)	Change Summary
services/.../seed.ts	In seedTransactionsAlerts, replaced businessRiskIds with businessIds in the function call.

Possibly related PRs

• fix: fetch seeded alerts #2427: Updated a similar function in seed.ts, modifying parameter handling for identifiers.

Suggested reviewers

• alonp99

Poem

I'm a little rabbit, hopping with delight,
Tweaking code at dawn and deep into the night.
With business IDs now set just right,
My code garden blooms, so fresh and bright.
Carrot cheers to CodeRabbit—coding feels light!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c44a8ec and 3026788.

📒 Files selected for processing (1)

• services/workflows-service/scripts/seed.ts (1 hunks)

🔇 Additional comments (1)

services/workflows-service/scripts/seed.ts (1)

1012-1012: LGTM! The fix correctly uses businessIds for seeding transaction alerts.

The change from businessRiskIds to businessIds is appropriate since transaction alerts should be associated with actual business entities rather than businesses specifically under risk review.

Let's verify that businessIds contains valid business entities:

✅ Verification successful

LGTM! The fix correctly updates to using businessIds for seeding transaction alerts.

• The shell scripts confirmed that businessIds is properly initialized (in services/workflows-service/scripts/generate-end-user.ts) and consistently used across the codebase, including in the alerts generation and the seed script.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that businessIds are properly initialized and used in the codebase

# Test 1: Check if businessIds are properly initialized
rg -A 5 "businessIds\s*=\s*\["

# Test 2: Verify the usage of businessIds in business creation
rg -A 10 "businessIds\.map"

Length of output: 3308

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.