Implement AccessLog support for Ballerina #1969
Conversation
AzeemMuzammil
requested review from
shafreenAnfar and
TharmiganK
as code owners
| @@ -144,6 +145,9 @@ public synchronized void addHttpContent(HttpContent httpContent) { | |||
| public HttpContent getHttpContent() { | |||
| HttpContent httpContent = this.blockingEntityCollector.getHttpContent(); | |||
| this.contentObservable.notifyGetListener(httpContent); | |||
| if (httpContent != null) { | |||
There was a problem hiding this comment.
blockingEntityCollector can contain multiple http contents right? In this case we only consider 1 content and set it to the carbon msg. Is that correct?
| @@ -53,6 +59,7 @@ public class ReceivingEntityBody implements SenderState { | |||
| private final Http2TargetHandler http2TargetHandler; | |||
| private final Http2ClientChannel http2ClientChannel; | |||
| private final Http2TargetHandler.Http2RequestWriter http2RequestWriter; | |||
| private Long contentLength = 0L; | |||
There was a problem hiding this comment.
im not sure about storing the content length in the state itself. while receiving the entity body, there is a possibility for the state to change right? if it changes, when receiving the response body again, a new ReceivingEntityBody state will be created that doesn't have the previous contentLength value. This is a possibility right? @TharmiganK
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
AzeemMuzammil
force-pushed
the
fb-access-log-improvement
branch
from
cf289ec
to
a8d6a34
Compare
AzeemMuzammil
force-pushed
the
fb-access-log-improvement
branch
3 times, most recently
from
252ce36
to
a8d2f46
Compare
|
AzeemMuzammil
force-pushed
the
fb-access-log-improvement
branch
from
e4adba3
to
a115354
Compare
AzeemMuzammil
force-pushed
the
fb-access-log-improvement
branch
from
a115354
to
3dfd0e1
Compare
native/src/main/java/io/ballerina/stdlib/http/api/logging/accesslog/HttpAccessLogConfig.java
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/http/api/logging/accesslog/HttpAccessLogConfig.java
Outdated
Show resolved
Hide resolved
| private List<HttpAccessLogMessage> getHttpAccessLogMessages(HttpCarbonMessage request) { | ||
| Object outboundAccessLogMessagesObject = request.getProperty(OUTBOUND_ACCESS_LOG_MESSAGES); | ||
| if (outboundAccessLogMessagesObject instanceof List<?> rawList) { | ||
| for (Object item : rawList) { |
There was a problem hiding this comment.
is there a possibility for the rawList to contain other LogMessage types than HttpAccessLogMessage?
There was a problem hiding this comment.
ATM, no only HttpAccessLogMessage
...io/ballerina/stdlib/http/transport/contractimpl/listener/states/http2/SendingEntityBody.java
Outdated
Show resolved
Hide resolved
.../java/io/ballerina/stdlib/http/transport/contractimpl/sender/states/ReceivingEntityBody.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/http/api/logging/HttpLogManager.java
Outdated
Show resolved
Hide resolved
Description
This pull request addresses the proposal detailed in ballerina-platform/ballerina-library#6111. The implementation has been completed, and comprehensive load tests were conducted to evaluate the performance with and without the access log feature enabled.
The load tests were executed for 30 minutes to ensure stability and performance consistency. Different backends and testing tools were utilized for HTTP/1.1 and HTTP/2 passthrough scenarios:
HTTP/1.1 Passthrough Scenarios:
HTTP/2 Passthrough Scenarios:
These configurations were chosen to handle each protocol's specific requirements and challenges effectively. Additionally, we have added the load test results and memory usage metrics for the HTTP/2 passthrough scenarios, providing detailed insights into the performance and resource consumption under heavy load conditions.
Load Test Results:
h1-h1-pass-through scenario (Apache JMeter)
h1-h2-pass-through scenario (Apache JMeter)
h2-h2-pass-through scenario (h2load)
Result
Heap
CPU
Result
Heap
CPU
h2-h1-pass-through scenario (h2load)
Result
Heap
CPU
Result
Heap
CPU
Examples
Checklist