Skip to content

Update LS for natural expression changes #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MaryamZi
Copy link
Member

Purpose

$title.

@MaryamZi MaryamZi force-pushed the natural-expr-update branch from 47a395e to f14d3f2 Compare July 17, 2025 03:54
@MaryamZi MaryamZi changed the base branch from main to natural-expr July 17, 2025 14:32
@MaryamZi MaryamZi changed the base branch from natural-expr to main July 18, 2025 09:06
@MaryamZi MaryamZi changed the base branch from main to natural-expr July 18, 2025 09:06
@MaryamZi MaryamZi requested review from dulajdilshan and Copilot July 18, 2025 09:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the language server (LS) to support the new "natural" expression changes in the Ballerina language. The changes add comprehensive completion support for the natural type across all language contexts.

  • Adds natural type completion as a basic type suggestion
  • Includes natural (..) {..} snippet completion for natural expressions with parameter and body placeholders
  • Updates test configuration files to include expected completion items for the natural type
Comments suppressed due to low confidence (1)

langserver-core/src/test/resources/completion/expression_context/config/typeof_expression_ctx_config5.json:474

  • The removal of the 'code' completion item suggests a behavior change that should be covered by tests. Ensure there are corresponding test cases that verify the 'code' completion is no longer available in this context.
    {

@MaryamZi MaryamZi merged commit 7a53687 into ballerina-platform:natural-expr Jul 21, 2025
3 checks passed
@MaryamZi MaryamZi deleted the natural-expr-update branch July 21, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants