docs: update errors #262
docs: update errors #262
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| | `MulOverflow()` | `0x0cde6c26` | | MockGyroECLPPool | | ||
| | `DivInterval()` | `0xe03f5d57` | | MockGyroECLPPool | | ||
| | `OwnableUnauthorizedAccount(address)` | `0x118cdaa7` | address account | MockLBPool | | ||
| | `OwnableInvalidOwner(address)` | `0x1e4fbdf7` | address owner | MockLBPool | |
There was a problem hiding this comment.
InvalidOwner is in the LBPPoolFactory; not sure where it's getting the "Ownable" from. We don't use that OZ contract directly (with LBPs, anyway; some of the hooks do).
| | `ContractNameAlreadyRegistered(ContractType,)` | `0xdecd1563` | ContractType contractType, string contractName | MevCaptureHook | | ||
| | `ContractNameInUseAsAlias(string,)` | `0xedcd5939` | string contractName, address contractAddress | MevCaptureHook | | ||
| | `ContractAliasInUseAsName(ContractType,)` | `0xc5949bff` | ContractType contractType, string contractName | MevCaptureHook | | ||
| | `ContractNameNotRegistered(string)` | `0xcd3599f9` | string contractName | MevCaptureHook | |
There was a problem hiding this comment.
ContractNameNotRegistered is in the BalancerContractRegistry
| | `AmplificationFactorTooLow()` | `0xab923323` | | MockStablePool | | ||
| | `AmplificationFactorTooHigh()` | `0x9b80d390` | | MockStablePool | | ||
| | `AmpUpdateDurationTooShort()` | `0xcd6b022a` | | MockStablePool | | ||
| | `AmpUpdateRateTooFast()` | `0x1c708b92` | | MockStablePool | |
There was a problem hiding this comment.
The AmpUpdate errors are in regular StablePool - are you doing this by reading the ABI, vs. reading the contracts? There really shouldn't be any "Mock" contracts. (They sometimes do declare their own errors, but just for tests, so I don't think they need to be documented.)
There was a problem hiding this comment.
I have moved to taking the abi from the deployments repo now. The errors should now match what is actually deployed onchain
|
@EndymionJkb I have updated the way how I fetch & generate the error codes. I now use some (not all) of the contracts in the deployment repo. I could add all the remaining ones and update the pr, but figured for now the relevant ones are included. Let me know what you think about it. |
Working on automating the error code updates.