- Added submenus for the Links. #285

VisionR1 · 2025-03-16T16:52:39Z

Added submenus for the Links.

Since, PixelFlasher is the most useful and know tool for all, i think for lot users (demanding) need more details, so i have create submenus (XDA and GitHub) with a few more links for useful threads, with the already existing icons.

- Added submenu for the Links. Since, PixelFlasher is the most useful and know tool for all, i think for lot users (demanding) need more details, so i have create submenu (XDA and GitHub) with a few more links for useful threads, with the already existing icons.

badabing2005 · 2025-03-16T20:01:52Z

Thanks for the PR.
I don't mind adding the XDA links, but the Github links I think there's no point.
The app goes one step further, and it allows you install any of those modules.

VisionR1 · 2025-03-16T20:45:21Z

Thanks for the PR. I don't mind adding the XDA links, but the Github links I think there's no point. The app goes one step further, and it allows you install any of those modules.

I didn't add the links for the GitHub, you had it already inside in the Main.py, I only added the links for XDA.

i just put it in submenu, to be more organized.

badabing2005 · 2025-03-16T21:07:37Z

Right, thanks for pointing out.
Here's what I suggest, let's keep then under the links submenu, which is already a submenu of Help
Too many nested menus could be a usability issue.
Let's change the icons of the Github links to Github, to be differentiator.
Say goes for the XDA sub-menu
If you want to do it, go for it, otherwise, I'll take care of it.

Thanks

VisionR1 · 2025-03-16T21:43:46Z

Right, thanks for pointing out. Here's what I suggest, let's keep then under the links submenu, which is already a submenu of Help Too many nested menus could be a usability issue. Let's change the icons of the Github links to Github, to be differentiator. Say goes for the XDA sub-menu If you want to do it, go for it, otherwise, I'll take care of it.

Thanks

In short, as you originally had it.
So put back the GitHub links to main and and put the proper icons ? Remove the XDA submenu and keep the XDA links to main or remove and the links?

badabing2005 · 2025-03-16T21:54:57Z

No don't remove XDA links, just put them under
Help | Links
Like all the links.
Github links would have the Github icon
Guides would keep the ? icon like they have now
Links would keep links icon like the have now
New XDA threads would have the XDA icon
The new XDA threads would also have a grouping separator line

VisionR1 · 2025-03-16T22:26:12Z

No don't remove XDA links, just put them under Help | Links Like all the links. Github links would have the Github icon Guides would keep the ? icon like they have now Links would keep links icon like the have now New XDA threads would have the XDA icon The new XDA threads would also have a grouping separator line

Exactly.
i will do it tomorrow. 👍🏻

You want new PR, or make all the changes to this?

VisionR1 · 2025-03-17T09:50:30Z

@badabing2005
This project https://github.com/TheFreeman193/PIFS is abonted, you want me to remove it or keep it?

badabing2005 · 2025-03-17T12:19:28Z

Sure why not

VisionR1 · 2025-03-17T12:21:26Z

Sure why not

I asked, maybe you still want it for the info.

Done. 👍🏻

- Delete submenu (XDA and GitHub). - XDA new Links. - Proper icons for GitHub and XDA Links. - Remove https://github.com/TheFreeman193/PIFS because it is abandoned.

badabing2005 · 2025-03-17T13:17:17Z

Main.py

        self.linksMenuItem6.SetBitmap(images.open_link_24.GetBitmap())
-        self.linksMenuItem7.SetBitmap(images.open_link_24.GetBitmap())
+        self.linksMenuItem7.SetBitmap(images.open_link_24.GetBitmap())       


remove empty space

badabing2005 · 2025-03-17T13:17:27Z

Main.py

        self.Bind(wx.EVT_MENU, self._on_link_clicked, self.linksMenuItem1)
        self.Bind(wx.EVT_MENU, self._on_link_clicked, self.linksMenuItem2)
        self.Bind(wx.EVT_MENU, self._on_link_clicked, self.linksMenuItem3)
        self.Bind(wx.EVT_MENU, self._on_link_clicked, self.linksMenuItem4)
        self.Bind(wx.EVT_MENU, self._on_link_clicked, self.linksMenuItem5)
        self.Bind(wx.EVT_MENU, self._on_link_clicked, self.linksMenuItem6)
-        self.Bind(wx.EVT_MENU, self._on_link_clicked, self.linksMenuItem7)
+        self.Bind(wx.EVT_MENU, self._on_link_clicked, self.linksMenuItem7)       


remove empty space

badabing2005 · 2025-03-17T13:18:17Z

Main.py

@@ -1874,48 +1874,55 @@ def _build_menu_bar(self):
        # separator
        help_menu.AppendSeparator()
        # Links Submenu
-        links = wx.Menu()
+        links = wx.Menu()       
+        self.linksMenuItem15 = links.Append(wx.ID_ANY, "osm0sis\'s PIF FAQ")


Guides has to be on Top, not XDA links.

badabing2005 · 2025-03-17T13:20:26Z

Main.py

+                self.linksMenuItem11.GetId(): (FACTORY_IMAGES_FOR_WATCH_DEVICES, "Factory Images for Pixel Watches"),
+                self.linksMenuItem12.GetId(): (FULL_OTA_IMAGES_FOR_BETA, "Full OTA Images for Pixel Beta 15"),
+                self.linksMenuItem13.GetId(): (FACTORY_IMAGES_FOR_BETA, "Factory Images for Pixel Beta 15"),
+                self.linksMenuItem14.GetId(): ('https://github.com/5ec1cff/TrickyStore', "5ec1cff's TrickyStore"),


Don't hardcode the links in the Main.py
Define them in the constants.py like the others and use the constant instead.

badabing2005 · 2025-03-17T13:20:34Z

Main.py

+                self.linksMenuItem12.GetId(): (FULL_OTA_IMAGES_FOR_BETA, "Full OTA Images for Pixel Beta 15"),
+                self.linksMenuItem13.GetId(): (FACTORY_IMAGES_FOR_BETA, "Factory Images for Pixel Beta 15"),
+                self.linksMenuItem14.GetId(): ('https://github.com/5ec1cff/TrickyStore', "5ec1cff's TrickyStore"),
+                self.linksMenuItem15.GetId(): ('https://xdaforums.com/t/pif-faq.4653307/', "osm0sis's PIF FAQ"),


Don't hardcode the links in the Main.py
Define them in the constants.py like the others and use the constant instead.

badabing2005 · 2025-03-17T13:20:42Z

Main.py

+                self.linksMenuItem14.GetId(): ('https://github.com/5ec1cff/TrickyStore', "5ec1cff's TrickyStore"),
+                self.linksMenuItem15.GetId(): ('https://xdaforums.com/t/pif-faq.4653307/', "osm0sis's PIF FAQ"),
+                self.linksMenuItem16.GetId(): ('https://xdaforums.com/t/info-play-integrity-api-replacement-for-safetynet.4479337/', "V0latyle\'s PI API Info"),
+                self.linksMenuItem17.GetId(): ('https://xdaforums.com/t/module-play-integrity-fix-safetynet-fix.4607985/', "chiteroman's PlayIntegrityFix"),


Don't hardcode the links in the Main.py
Define them in the constants.py like the others and use the constant instead.

badabing2005 · 2025-03-17T13:20:46Z

Main.py

+                self.linksMenuItem15.GetId(): ('https://xdaforums.com/t/pif-faq.4653307/', "osm0sis's PIF FAQ"),
+                self.linksMenuItem16.GetId(): ('https://xdaforums.com/t/info-play-integrity-api-replacement-for-safetynet.4479337/', "V0latyle\'s PI API Info"),
+                self.linksMenuItem17.GetId(): ('https://xdaforums.com/t/module-play-integrity-fix-safetynet-fix.4607985/', "chiteroman's PlayIntegrityFix"),
+                self.linksMenuItem18.GetId(): ('https://xdaforums.com/t/tricky-store-bootloader-keybox-spoofing.4683446/', "Tricky Store (Support Thread)"),


Don't hardcode the links in the Main.py
Define them in the constants.py like the others and use the constant instead.

badabing2005 · 2025-03-17T13:21:11Z

Main.py

-        links = wx.Menu()
+        links = wx.Menu()       
+        self.linksMenuItem15 = links.Append(wx.ID_ANY, "osm0sis\'s PIF FAQ")
+        self.linksMenuItem16 = links.Append(wx.ID_ANY, "V0latyle\'s PI API Info")


Guides has to be on Top, not XDA links.

badabing2005 · 2025-03-17T13:21:15Z

Main.py

+        links = wx.Menu()       
+        self.linksMenuItem15 = links.Append(wx.ID_ANY, "osm0sis\'s PIF FAQ")
+        self.linksMenuItem16 = links.Append(wx.ID_ANY, "V0latyle\'s PI API Info")
+        self.linksMenuItem17 = links.Append(wx.ID_ANY, "chiteroman\'s PlayIntegrityFix")


Guides has to be on Top, not XDA links.

badabing2005 · 2025-03-17T13:21:21Z

Main.py

+        self.linksMenuItem15 = links.Append(wx.ID_ANY, "osm0sis\'s PIF FAQ")
+        self.linksMenuItem16 = links.Append(wx.ID_ANY, "V0latyle\'s PI API Info")
+        self.linksMenuItem17 = links.Append(wx.ID_ANY, "chiteroman\'s PlayIntegrityFix")
+        self.linksMenuItem18 = links.Append(wx.ID_ANY, "Tricky Store (Support Thread)")


Guides has to be on Top, not XDA links.

VisionR1 · 2025-03-17T14:33:33Z

Thanks for all the info.
Still i'm beginner.

Now ?

Update Main.py

58f53dc

- Added submenu for the Links. Since, PixelFlasher is the most useful and know tool for all, i think for lot users (demanding) need more details, so i have create submenu (XDA and GitHub) with a few more links for useful threads, with the already existing icons.

Update Main.py

a167d63

- Delete submenu (XDA and GitHub). - XDA new Links. - Proper icons for GitHub and XDA Links. - Remove https://github.com/TheFreeman193/PIFS because it is abandoned.

badabing2005 requested changes Mar 17, 2025

View reviewed changes

VisionR1 added 2 commits March 17, 2025 16:31

Update Main.py

f11581c

Update constants.py

8deeff6

badabing2005 merged commit 74177f0 into badabing2005:main Mar 17, 2025

- Added submenus for the Links. #285

- Added submenus for the Links. #285

Uh oh!

Conversation

VisionR1 commented Mar 16, 2025

Uh oh!

badabing2005 commented Mar 16, 2025

Uh oh!

VisionR1 commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

badabing2005 commented Mar 16, 2025

Uh oh!

VisionR1 commented Mar 16, 2025

Uh oh!

badabing2005 commented Mar 16, 2025

Uh oh!

VisionR1 commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VisionR1 commented Mar 17, 2025

Uh oh!

badabing2005 commented Mar 17, 2025

Uh oh!

VisionR1 commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VisionR1 commented Mar 17, 2025

Uh oh!

Uh oh!

VisionR1 commented Mar 16, 2025 •

edited

Loading

VisionR1 commented Mar 16, 2025 •

edited

Loading

VisionR1 commented Mar 17, 2025 •

edited

Loading