Compressor bpzip2 #937
Open
Compressor bpzip2 #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works like bzip2 and as a drop-in-replacement for it.
oogali
approved these changes
Jul 22, 2020
|
LGTM Although, I have one more request: can you squash your commits into a single one? |
|
Hey that looks great, but I'm wondering whether we could merge this with the bzip2 module and just have a flag to select the actual binary used for compression? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added compressor "Parallel BZIP2" (pbzip2) for making use of multiple cores when compressing backups.
Tested on Ubuntu Linux 18.04LTS and ruby 2.4.3p205 (2017-12-14 revision 61247) [x86_64-linux].