Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving mysql password to env variable #1001

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GeNiuS69
Copy link

Moving mysql password to MYSQL_PWD variable.
It allows increase security level and prevent warning about cli password: mysqldump: [Warning] Using a password on the command line interface can be insecure.

@elthariel
Copy link
Contributor

I don't like this way of setting env vars on subprocess. But it doesn't seem like Open4 provides another way.

WDYT @tomash ?

@tomash
Copy link
Contributor

tomash commented Feb 25, 2024

An env var is way better than a (potentially logged!) command-line argument. So in general I'm +1 for this PR, as soon as it comes with appropiate documentation.

Moving forward, we should handle secrets in env vars via nowadays-standard https://github.com/bkeepers/dotenv so that they can still be loaded from a file that's never versioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants