Skip to content

Internet availability checks #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
konraddysput merged 1 commit into from
Sep 6, 2024
Merged

Internet availability checks #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Runtime/BacktraceDatabase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ internal void Update()
}
if (_breadcrumbs != null)
{
_breadcrumbs.Update();
_breadcrumbs.Update(Time.unscaledTime);
}
LastFrameTime = Time.unscaledTime;
if (!DatabaseSettings.AutoSendMode)
Expand Down
4 changes: 2 additions & 2 deletions Runtime/Model/Breadcrumbs/BacktraceBreadcrumbs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,9 @@ public double BreadcrumbId()
return LogManager.BreadcrumbId();
}

public void Update()
public void Update(float time)
{
EventHandler.Update();
EventHandler.Update(time);
}

public static bool CanStoreBreadcrumbs(UnityEngineLogLevel logLevel, BacktraceBreadcrumbType backtraceBreadcrumbsLevel)
Expand Down
11 changes: 10 additions & 1 deletion Runtime/Model/Breadcrumbs/BacktraceBreadcrumbsEventHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ internal sealed class BacktraceBreadcrumbsEventHandler
private BacktraceBreadcrumbType _registeredLevel;
private NetworkReachability _networkStatus = NetworkReachability.NotReachable;
private Thread _thread;
private float _lastUpdateTime = 0;

// time in seconds between internet availability checks
private float INTERNET_AVAILABILITY_CHECK_INTERVAL_SEC = 30;
public BacktraceBreadcrumbsEventHandler(BacktraceBreadcrumbs breadcrumbs)
{
_thread = Thread.CurrentThread;
Expand Down Expand Up @@ -151,8 +155,13 @@ private void LogNewNetworkStatus(NetworkReachability status)
Log(string.Format("Network:{0}", status), LogType.Log, BreadcrumbLevel.System);
}

internal void Update()
internal void Update(float time)
{
if (time - _lastUpdateTime < INTERNET_AVAILABILITY_CHECK_INTERVAL_SEC && _lastUpdateTime != 0)
{
return;
}
_lastUpdateTime = time;
if (_registeredLevel.HasFlag(BacktraceBreadcrumbType.System) && Application.internetReachability != _networkStatus)
{
LogNewNetworkStatus(Application.internetReachability);
Expand Down
2 changes: 1 addition & 1 deletion Runtime/Model/Breadcrumbs/IBacktraceBreadcrumbs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public interface IBacktraceBreadcrumbs
string GetBreadcrumbLogPath();
double BreadcrumbId();
void UnregisterEvents();
void Update();
void Update(float time);
string Archive();
}
}