Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity unhandled exception proguard flow #221

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

konraddysput
Copy link
Collaborator

@konraddysput konraddysput commented Jun 25, 2024

Why

Unity uncaught exception handler can also capture unhandled exceptions thrown by the managed Java code. The following code in the java managed layer can be captured by Unity exception handler:

  throw new RuntimeException("Unity-test: Uncaught JVM exception");

In this flow we didn't apply proguard symbolication. This patch makes sure the symbolication flow is applied in the unity uncaught exception handler.

ref: BT-2993

@konraddysput konraddysput added the bug Something isn't working label Jun 25, 2024
@konraddysput konraddysput self-assigned this Jun 25, 2024
@konraddysput konraddysput changed the base branch from master to bugfix/empty-queue June 25, 2024 16:46
@konraddysput konraddysput merged commit 96a0a62 into bugfix/empty-queue Jun 26, 2024
10 checks passed
@konraddysput konraddysput deleted the bugfix/proguard-exception-flow branch June 26, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants