Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java crash handler on not extracted libraries #218

Merged

Conversation

konraddysput
Copy link
Collaborator

@konraddysput konraddysput commented Jun 14, 2024

Why

This update allows using java crash handler when the native libraries are not extracted. This change only works on Android.

In the current implementation, we're using Java crash handler as a fallback function. In most cases, we know that our native crash handler should be available and we know most of our clients might not have proguard configuration set up by default

ref: BT-2979

@konraddysput konraddysput added the enhancement New feature or request label Jun 14, 2024
@konraddysput konraddysput self-assigned this Jun 14, 2024
Copy link
Contributor

@rick-bt rick-bt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime/Native/Android/NativeClient.cs#255
When we Directory.CreateDirectory(databasePath), can we check that it was created successfully? Would be helpful to know if that create failed.

@konraddysput
Copy link
Collaborator Author

Runtime/Native/Android/NativeClient.cs#255 When we Directory.CreateDirectory(databasePath), can we check that it was created successfully? Would be helpful to know if that create failed.

Directory.CreateDirectory ensures that the directory exists after it is called. Its in the c# implementation

@konraddysput konraddysput merged commit f53f346 into master Jun 17, 2024
10 checks passed
@konraddysput konraddysput deleted the improvement/java-crash-handler-on-not-extracted-libraries branch June 26, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants