Allow defining not supported variables #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf2711
approved these changes
Apr 29, 2024
konraddysput
deleted the
improvement/allow-defining-not-supported-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The configuration object created by a user to create
BacktraceClientrequires properties available only in specific OSes. When the user needs to switch between different OS builds, most of the time it requires wrapping the initialization object with the #ifdef which is not a great user experience.The current change allows to define all properties in the backtrace configuration object. Not supported properties on specific OS will be marked as unsupported via NotSupported attribute.
ref: BT-535