Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add PDB #248

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add PDB #248

wants to merge 2 commits into from

Conversation

Prims47
Copy link

@Prims47 Prims47 commented Feb 5, 2025 •
edited
Loading

Description of the change

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@Prims47 Prims47 requested a review from a team as a code owner February 5, 2025 17:45
@ChrisJBurns
Copy link
Contributor

@Prims47 Got a couple failures in pipeline

@Prims47
Copy link
Author

Prims47 commented Feb 6, 2025 •
edited
Loading

@Prims47 Got a couple failures in pipeline

@ChrisJBurns Indeed => The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.

I launch ct lint + helm template and eveything is ok on my side

@ChrisJBurns
Copy link
Contributor

@Prims47 You should be able to rebase with main now and have the Python error fixed due to the merging of #249

feat: Add PDB
10a972d 
Signed-off-by: Ilan Zerath <[email protected]>
@Prims47
Copy link
Author

Prims47 commented Feb 11, 2025

@Prims47 You should be able to rebase with main now and have the Python error fixed due to the merging of #249

@ChrisJBurns It's up to date 😄

tumido
tumido reviewed Feb 11, 2025
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit/suggestion. Otherwise it looks good 🙂

@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Feb 21, 2025
@ChrisJBurns ChrisJBurns removed the stale label Feb 21, 2025
tumido
tumido requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry again for a late response. I had to focus on different projects... 🙈

charts/backstage/Chart.yaml Outdated
@@ -38,4 +38,4 @@ sources:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.3.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump a minor version here? I guess you're introducing a new feature here, it's not a bugfix.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Mar 6, 2025
@github-actions github-actions bot closed this Mar 12, 2025
@ChrisJBurns ChrisJBurns reopened this Mar 12, 2025
@github-actions github-actions bot removed the stale label Mar 13, 2025
ChrisJBurns
ChrisJBurns reviewed Mar 16, 2025
View reviewed changes
charts/backstage/README.md
@@ -2,7 +2,7 @@
# Backstage Helm Chart

[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/backstage)](https://artifacthub.io/packages/search?repo=backstage)
![Version: 2.4.0](https://img.shields.io/badge/Version-2.4.0-informational?style=flat-square)
![Version: 2.5.0](https://img.shields.io/badge/Version-2.4.0-informational?style=flat-square)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![Version: 2.5.0](https://img.shields.io/badge/Version-2.4.0-informational?style=flat-square)
![Version: 2.5.0](https://img.shields.io/badge/Version-2.5.0-informational?style=flat-square)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prims47 I think you should be ok to accept the suggestion above and then the tests should pass. We can then get this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJBurns ChrisJBurns ChrisJBurns left review comments

@tumido tumido tumido requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Prims47 @ChrisJBurns @tumido