Issue #6520: Show config storage locations in status report #4739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to: backdrop/backdrop-issues#6520 |
|
Tugboat has finished building a preview for this pull request! Website: https://pr4739-xqhithgkmztryqy7niib52hrhljn6muh.tugboatqa.com/ This preview will automatically expire on the 14th of July, 2024. |
jenlampton
reviewed
May 15, 2024
| $config_storage_active = config_get_config_storage('active'); | ||
| $config_storage_staging = config_get_config_storage('staging'); | ||
| $backend = array( | ||
| '@backend' => is_a($config_storage_active, 'ConfigFileStorage') ? t('files') : t('database'), |
There was a problem hiding this comment.
If we run this through t() and then also run it through t() in t('Active configuration: @backend', $backend) it's going to end up double escaped.
Can we do t('Active configuration: !backend', ...), instead?
jenlampton
reviewed
May 15, 2024
| '@backend' => is_a($config_storage_active, 'ConfigFileStorage') ? t('files') : t('database'), | ||
| ); | ||
| $config_storage_locations = array( | ||
| 'active' => t('Active configuration: @backend', $backend), |
There was a problem hiding this comment.
This isn't how t() works we need to pass it an array with keys that match what's in the string, like...
t('Active configuration: !backend', array('!backend' => $backend),
jenlampton
reviewed
May 15, 2024
| ); | ||
| $config_storage_locations = array( | ||
| 'active' => t('Active configuration: @backend', $backend), | ||
| 'staging' => t('Staging configuration: @backend', $backend), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes backdrop/backdrop-issues#6520