Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[helpers TS conversion] modules helpers #16527

Merged
merged 5 commits into from
May 29, 2024
Merged

[helpers TS conversion] modules helpers #16527

merged 5 commits into from
May 29, 2024

Conversation

amjed-98
Copy link
Contributor

Q                       A
Fixed Issues? Fixes part of #16500
Patch: Bug Fix? No
Major: Breaking Change? NO
Minor: New Feature? NO
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented May 23, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57050

@amjed-98 amjed-98 changed the title refactor: migrate importDeferProxy helper to TypeScript [helpers TS conversion]: importDeferProxy May 23, 2024
@amjed-98 amjed-98 changed the title [helpers TS conversion]: importDeferProxy [helpers TS conversion]: modules helper May 24, 2024
liuxingbaoyu
liuxingbaoyu approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I made a few changes for size and simplicity.

nicolo-ribaudo
nicolo-ribaudo approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo changed the title [helpers TS conversion]: modules helper [helpers TS conversion] modules helpers May 29, 2024
@nicolo-ribaudo nicolo-ribaudo merged commit 9a8c8ba into babel:main May 29, 2024
51 checks passed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amjed-98 @babel-bot @nicolo-ribaudo @liuxingbaoyu