Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Babel 8] Remove extra.shorthand #16521

Merged
merged 2 commits into from
Jun 3, 2024
Merged

[Babel 8] Remove extra.shorthand #16521

merged 2 commits into from
Jun 3, 2024

Conversation

liuxingbaoyu
Copy link
Member

@liuxingbaoyu liuxingbaoyu commented May 21, 2024 •
edited

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#2891
Any Dependency Changes?
License MIT

I changed testing tools to avoid a lot of duplication of tests.

@liuxingbaoyu liuxingbaoyu added the PR: Internal (next major) 🏠 A type of pull request used for our changelog categories for next major release label May 21, 2024
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57009

JLHwung
JLHwung approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

External tools might depend on the .extra.shorthand property, can we mark this PR as a breaking change? We should also update the migration docs for this change.

@nicolo-ribaudo nicolo-ribaudo added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release PR: Needs Docs and removed PR: Internal (next major) 🏠 A type of pull request used for our changelog categories for next major release labels May 30, 2024
@nicolo-ribaudo
Copy link
Member

The recommended migration should be checking node.shorthand rather than node.extra.shorthand.

@liuxingbaoyu liuxingbaoyu mentioned this pull request May 30, 2024
Merged
@nicolo-ribaudo nicolo-ribaudo merged commit 17a5502 into babel:main Jun 3, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liuxingbaoyu @babel-bot @nicolo-ribaudo @JLHwung