-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate helper metadata at build time #16501
Merged
nicolo-ribaudo
merged 19 commits into
babel:main
from
nicolo-ribaudo:static-helper-metata
May 22, 2024
Merged
Generate helper metadata at build time #16501
nicolo-ribaudo
merged 19 commits into
babel:main
from
nicolo-ribaudo:static-helper-metata
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57012 |
17a94db
to
7883619
Compare
liuxingbaoyu
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I like this!
0ca190e
to
0c29d67
Compare
c95ee9a
to
fc45887
Compare
6f9b0fc
to
168c0d2
Compare
nicolo-ribaudo
commented
May 20, 2024
this.v = value; | ||
this.k = kind; | ||
} | ||
|
||
export { _OverloadYield as default }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support for this is needed in #16510
This was referenced Jun 17, 2024
This was referenced Jun 18, 2024
This was referenced Jun 18, 2024
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2
The goal of this PR is to:
File
class that needs to be injected from@babel/core
to@babel/helpers
through.ensure(name, FileClass)
This PR reduces the time needed to process a single helper by half (
allHelpersNames.map(name => this.addHelper(name));
takes 100ms rather than 190ms on my machine)