Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix strict type ignored when mapping or filtering arrays #196

Merged
merged 1 commit into from
May 19, 2021
Merged

fix strict type ignored when mapping or filtering arrays #196

merged 1 commit into from
May 19, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented May 19, 2021

fixes #194

@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels May 19, 2021
@azjezz azjezz self-assigned this May 19, 2021
@coveralls
Copy link

coveralls commented May 19, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 856718644

  • 31 of 31 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 725317265: 0.0%
Covered Lines: 2978
Relevant Lines: 2978
💛 - Coveralls

@azjezz azjezz force-pushed the bug/strict-callable branch 2 times, most recently from dd9ffe9 to 83182a1 Compare May 19, 2021 11:45
@azjezz azjezz merged commit 60683bf into 1.6.x May 19, 2021
@azjezz azjezz deleted the bug/strict-callable branch May 19, 2021 11:49
azjezz
azjezz commented May 19, 2021
View reviewed changes
src/Psl/Dict/filter.php
/**
* @param Tv $v
*/
static fn($v): bool => $predicate($v)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$predicate is now called in user-land, so strict types apply :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azjezz @coveralls