fix(Core/Comments): Clarify quest level hiding configuration comments

[NoxMax]

Changes Proposed:

Minor comment fix. Current comment implies that quests that are EQUAL TO Low/HighLevelHideDiff or more are hidden, when it's actually only quests that are MORE THAN Low/HighLevelHideDiff that are hidden. The logic can be seen at PlayerQuest.cpp with CONFIG_QUEST_LOW_LEVEL_HIDE_DIFF and CONFIG_QUEST_HIGH_LEVEL_HIDE_DIFF.

Screenshot for example. If the comment was correct, then at default value of 4, this level 14 marker should be hidden from level 18:

Second, -1 - (Disabled, Show all available quest marks) is removed as a possible option. Note the comment and code logic in WorldConfig.cpp:

// note: disable value (-1) will assigned as 0xFFFFFFF, to prevent overflow at calculations limit it to max possible player level MAX_LEVEL(100)
SetConfigValue<uint32>(CONFIG_QUEST_LOW_LEVEL_HIDE_DIFF, "Quests.LowLevelHideDiff", 4, ConfigValueCache::Reloadable::Yes, [](uint32 const& value) { return value <= MAX_LEVEL; }, "<= MAX_LEVEL");
SetConfigValue<uint32>(CONFIG_QUEST_HIGH_LEVEL_HIDE_DIFF, "Quests.HighLevelHideDiff", 7, ConfigValueCache::Reloadable::Yes, [](uint32 const& value) { return value <= MAX_LEVEL; }, "<= MAX_LEVEL"); 

A config of -1 is rejected as the bound is MAX_LEVEL. It errors out if you use it:

> Config: Bad value defined for name 'Quests.LowLevelHideDiff', going to use '4'
 instead
> Config: Bad value defined for name 'Quests.HighLevelHideDiff', going to use '7
' instead 

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[TheSCREWEDSoftware]

I dont recall now, does the comment for the Creature level is properly phrased?

E.g Level 9 Player would see a level 4 grey (a 5 green)
A level 8 player would see a level 4 and 5 green

[NoxMax]

This config is about hiding lower level quests, as a static difference value. So with the default 4 value, at level 20 quests that are < 16 will be hidden, and at level 80 quests that are < 76 will be hidden.

If you are referring about when a green quest/creature becomes grey, that is not a static value. A level 80 will see a quest/creature as low as 72 (8 diff) as green, but a level 20 will see a quest/creature as low as 14 (6 diff) as green.

This table lists it all (and it's correct as far as WOTLK) https://warcraft.wiki.gg/wiki/Mob_difficulty_colors

[NoxMax]

Also removed the mention of -1 as an option. It's not valid.